Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable truststore test in FIPS mode #84745

Merged

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Mar 8, 2022

FIPS JSSE cannot read the common truststore formats (because the
underlying crypto algorithms are not FIPS compliant).
That means the testDeprecationOfTruststoreWithNoTrustedEntries test
is not applicable on FIPS

Resolves: #84703

FIPS JSSE cannot read the common truststore formats (because the
underlying crypto algorithms are not FIPS compliant).
That means the `testDeprecationOfTruststoreWithNoTrustedEntries` test
is not applicable on FIPS

Resolves: elastic#84703
@tvernum tvernum added >test Issues or PRs that are addressing/adding tests :Security/FIPS Running ES in FIPS 140-2 mode labels Mar 8, 2022
@tvernum tvernum requested a review from justincr-elastic March 8, 2022 02:03
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Mar 8, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@justincr-elastic justincr-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum
Copy link
Contributor Author

tvernum commented Mar 18, 2022

@elasticmachine update branch

@tvernum tvernum added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Mar 18, 2022
@tvernum
Copy link
Contributor Author

tvernum commented Mar 18, 2022

@elasticmachine run elasticsearch-ci/part-1-fips s'il vous plaît
Hit by #85086

@elasticsearchmachine elasticsearchmachine merged commit db2d446 into elastic:7.17 Mar 18, 2022
@tvernum tvernum deleted the fix/84703-empty-truststore-fips branch March 18, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/FIPS Running ES in FIPS 140-2 mode Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v7.17.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants