Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BWC test for field-caps #84455

Merged
merged 8 commits into from
Mar 15, 2022
Merged

Add BWC test for field-caps #84455

merged 8 commits into from
Mar 15, 2022

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 28, 2022

Relates #83494

@dnhatn
Copy link
Member Author

dnhatn commented Mar 1, 2022

run elasticsearch-ci/part-1

@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Mar 2, 2022
@dnhatn dnhatn marked this pull request as ready for review March 2, 2022 18:26
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories and removed >non-issue labels Mar 2, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Mar 2, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn requested review from javanna and jtibshirani March 3, 2022 02:12
javanna
javanna reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this, this is great to have, I left a couple of questions.

qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/FieldCapsIT.java Outdated Show resolved Hide resolved
qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/FieldCapsIT.java Show resolved Hide resolved
qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/FieldCapsIT.java Show resolved Hide resolved
@javanna javanna requested a review from romseygeek March 7, 2022 11:37
@javanna
Copy link
Member

javanna commented Mar 7, 2022

@romseygeek I added you as a reviewer, I believe this is helpful also to test the filters and types functionalities that you recently added.

@dnhatn dnhatn removed the request for review from jtibshirani March 8, 2022 02:28
@dnhatn dnhatn mentioned this pull request Mar 9, 2022
Merged
javanna
javanna approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Mar 15, 2022

Thanks Luca!

@dnhatn dnhatn merged commit 273eedd into elastic:master Mar 15, 2022
@dnhatn dnhatn deleted the bwc_field_caps branch March 15, 2022 14:06
@dnhatn dnhatn mentioned this pull request Mar 15, 2022
Merged
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Mar 15, 2022
@dnhatn
Add BWC test for field-caps (elastic#84455)
3b3b1f9 
Relates elastic#83494
@dnhatn dnhatn mentioned this pull request Mar 15, 2022
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.1
✅ 7.17

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Mar 15, 2022
@dnhatn
Add BWC test for field-caps (elastic#84455)
22b1daf 
Relates elastic#83494
elasticsearchmachine pushed a commit that referenced this pull request Mar 15, 2022
@dnhatn
Add BWC test for field-caps (#84455) (#84989)
42c8300 
Relates #83494
elasticsearchmachine pushed a commit that referenced this pull request Mar 15, 2022
@dnhatn
[7.17] Add BWC test for field-caps (#84455) (#84990)
c831a61 
* Add BWC test for field-caps (#84455)

Relates #83494

* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

@romseygeek romseygeek Awaiting requested review from romseygeek

Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Clients Meta label for clients team Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.17.2 v8.1.1 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dnhatn @elasticmachine @javanna @elasticsearchmachine @sethmlarson