Simplify Store$MetadataSnapshot and friends #84357
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportNodesListShardStoreMetadata$StoreFilesMetadata
andStore$MetadataSnapshot
are both morally-speaking records, andLoadedMetadata
is really the same asMetadataSnapshot
. This committurns them into real records, gets rid of the unnecessary extra class,
and renames some of the accessors.
Spotted while working on #84034