Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra section on doc-value-only fields to documentation #84209

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Feb 22, 2022

Adds a dedicated section for doc-value-only fields to the docs that can be linked to.

@ywelsch ywelsch added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types auto-backport-and-merge v8.2.0 v8.1.1 labels Feb 22, 2022
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Feb 22, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@ywelsch ywelsch requested a review from javanna February 22, 2022 08:10
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


<1> The `status_code` field is a regular long field.
<2> The `session_id` field has `index` disabled, and is therefore a
doc-value-only long field.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for extreme clarity, would it make sense to mention here too that doc_values are on by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ good idea

@ywelsch ywelsch merged commit 083bb8a into elastic:master Feb 22, 2022
@ywelsch
Copy link
Contributor Author

ywelsch commented Feb 22, 2022

Thanks @javanna!

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:
An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 84209

ywelsch added a commit that referenced this pull request Feb 22, 2022
Adds a dedicated section for doc-value-only fields to the docs that can be linked to.
probakowski pushed a commit to probakowski/elasticsearch that referenced this pull request Feb 23, 2022
…84209)

Adds a dedicated section for doc-value-only fields to the docs that can be linked to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v8.1.1 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants