Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix license feature test cleanup #84020

Conversation

droberts195
Copy link
Contributor

Testing license features for can cause the .ml-stats index to
be created some time after the tests complete. This can cause
the post-test cleanup to fail.

This change fixes the problem by waiting for pending tasks in
the first stage cleanup, before the main cleanup methods run
in the base classes.

Fixes #83923

Testing license features for can cause the .ml-stats index to
be created some time after the tests complete. This can cause
the post-test cleanup to fail.

This change fixes the problem by waiting for pending tasks in
the first stage cleanup, before the main cleanup methods run
in the base classes.

Fixes elastic#83923
@droberts195 droberts195 added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.2.0 v8.1.1 labels Feb 16, 2022
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Feb 16, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Feb 16, 2022
@elasticsearchmachine elasticsearchmachine merged commit 15e522e into elastic:master Feb 16, 2022
@droberts195 droberts195 deleted the fix_license_feature_test_cleanup branch February 16, 2022 12:41
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.1

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 16, 2022
Testing license features for can cause the .ml-stats index to be created
some time after the tests complete. This can cause the post-test cleanup
to fail.

This change fixes the problem by waiting for pending tasks in the first
stage cleanup, before the main cleanup methods run in the base classes.

Fixes elastic#83923
droberts195 added a commit that referenced this pull request Feb 16, 2022
Testing license features for can cause the .ml-stats index to be created
some time after the tests complete. This can cause the post-test cleanup
to fail.

This change fixes the problem by waiting for pending tasks in the first
stage cleanup, before the main cleanup methods run in the base classes.

Fixes #83923
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Feb 16, 2022
…ijun/elasticsearch into fix-none-tsdb-index-dimension-tests

* 'fix-none-tsdb-index-dimension-tests' of github.com:weizijun/elasticsearch: (37 commits)
  [docs] Mention JDK 17 in the Contributing docs (elastic#84018)
  Fix GeoIpDownloader startup during rolling upgrade (elastic#84000)
  Script: Fields API for Dense Vector (elastic#83550)
  Move InferenceConfigUpdate under VersionedNamedWriteable (elastic#84022)
  [ML] Fix license feature test cleanup (elastic#84020)
  Replace deprecated api in artifact transforms (elastic#84015)
  QL: Add leniency option to SQL CLI (elastic#83795)
  [Stack Monitoring] add kibana_stats version alias to -mb template (elastic#83930)
  Optimize spliterator for ImmutableOpenMap (elastic#83899)
  Feature usage actions for archive (elastic#83931)
  Use latch to speedup multi feature migration test (elastic#84007)
  Make action names available in NodeClient (elastic#83919)
  [DOCS] Re-add HTTP proxy setings from elastic#82737 (elastic#84001)
  Add CI matrix configuration for snapshot BWC versions (elastic#83990)
  Update YAML Rest tests to check for product header on all responses (elastic#83290)
  TSDB: Add time series aggs cancellation (elastic#83492)
  [DOCS] Fix percolate query headings (elastic#83988)
  [DOCS] Move tip for percolate query example (elastic#83972)
  Simplify LocalExporter cleaner function to fix failing tests (elastic#83812)
  [GCE Discovery] Correcly handle large zones with 500 or more instances (elastic#83785)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.1.1 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] TestFeatureLicenseTrackingIT testFeatureTrackingInferenceModelPipeline failing
4 participants