TSDB: improve error message for nested fields #83837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Nested fields have never been supported in time_series mode but their error message was something along the lines of "nested fields don't work when you've enabled index sorting". Which is *true*, but when you put an index into time_series mode you don't explicitly enable index sorting - time_series mode does that for you. So the message is confusing. This gives you a more explicit "nested fields don't work in time_series mode". I've also added tests for nested dimensions outside of time series mode. We didn't have any such tests and it's nice to assert how they currently work.
|
Thanks @csoulios ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested fields have never been supported in time_series mode but their
error message was something along the lines of "nested fields don't work
when you've enabled index sorting". Which is true, but when you put
an index into time_series mode you don't explicitly enable index sorting
gives you a more explicit "nested fields don't work in time_series
mode".
I've also added tests for nested dimensions outside of time series mode.
We didn't have any such tests and it's nice to assert how they currently
work.