Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doc-values only search on ip fields #82929

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jan 24, 2022

Similar to #82409, but for ip fields.

Allows searching on ip fields when those fields are not indexed (index: false) but just doc values are enabled.

This enables searches on archive data, which has access to doc values but not index structures. When combined with searchable snapshots, it allows downloading only data for a given (doc value) field to quickly filter down to a select set of documents.

Relates #81210 and #52728

@ywelsch ywelsch added :Search/Search Search-related issues that do not fall into other categories >enhancement labels Jan 24, 2022
@ywelsch ywelsch mentioned this pull request Jan 24, 2022
32 tasks
@ywelsch ywelsch marked this pull request as ready for review January 24, 2022 11:59
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jan 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@ywelsch ywelsch requested a review from javanna January 24, 2022 11:59
@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 24, 2022

@elasticmachine run elasticsearch-ci/part-1 (unrelated test failure)

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @ywelsch !

@ywelsch ywelsch merged commit d9f77fa into elastic:master Jan 25, 2022
@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 25, 2022

Thank you @javanna!

@ywelsch ywelsch mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants