Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add XContentFieldFilter (#81970)" #82897

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Revert "Add XContentFieldFilter (#81970)" #82897

merged 1 commit into from
Jan 20, 2022

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Jan 20, 2022

This reverts commit 4560a0c. It
unexpectedly caused #82891.

@nik9000 nik9000 added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types v8.1.0 labels Jan 20, 2022
@nik9000 nik9000 requested a review from romseygeek January 20, 2022 21:13
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Jan 20, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 20, 2022
@nik9000
Copy link
Member Author

nik9000 commented Jan 20, 2022

@jportner let me know that #82891 is really hurting the kibana folk so I'm going to revert your work in #81970 for the moment. If you have time could you look at #82891? It looks like we were missing some important tests!

@nik9000
Revert "Add XContentFieldFilter (elastic#81970)"
46f7063 
This reverts commit 4560a0c. It
unexpectedly caused elastic#82891.
@elasticsearchmachine elasticsearchmachine merged commit 8892b77 into elastic:master Jan 20, 2022
@mushao999
Copy link
Contributor

mushao999 commented Jan 21, 2022 •
edited
Loading

@jportner let me know that #82891 is really hurting the kibana folk so I'm going to revert your work in #81970 for the moment. If you have time could you look at #82891? It looks like we were missing some important tests!

@nik9000 I'am sorry for the issue. I will try to fix this issue and add some tests.

@nik9000
Copy link
Member Author

nik9000 commented Jan 24, 2022

@nik9000 I'am sorry for the issue. I will try to fix this issue and add some tests.

Happens to the best of us. Good luck!

@mushao999 mushao999 mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek Awaiting requested review from romseygeek

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nik9000 @elasticmachine @mushao999 @elasticsearchmachine