Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hunspell dictionaries location config #82704

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Remove Hunspell dictionaries location config #82704

merged 3 commits into from
Jan 24, 2022

Conversation

Ekimik
Copy link
Contributor

@Ekimik Ekimik commented Jan 18, 2022

User can no longer set location for Hunspell dictionaries. <config-dir>/hunspell directory is silently used everytime no matter what configuration is used (see code). So doc should not say it's possible.

@Ekimik
Remove Hunspell dictionaries location config
6525be6 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used (see [code](https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/indices/analysis/HunspellService.java#L123)). So doc should not say it's possible.
@elasticsearchmachine elasticsearchmachine added v7.16.4 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 18, 2022
@jtibshirani jtibshirani added :Search Relevance/Analysis How text is split into tokens >docs General docs changes labels Jan 19, 2022
@elasticmachine elasticmachine added Team:Search Meta label for search team Team:Docs Meta label for docs team labels Jan 19, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig self-assigned this Jan 19, 2022
@jrodewig jrodewig self-requested a review January 19, 2022 22:31
@jrodewig
Copy link
Contributor

Thanks for making this change @Ekimik. I tested this locally and pushed some additional changes to remove other references to the indices.analysis.hunspell.dictionary.location setting.

@romseygeek Since I contributed, do you mind giving this a quick review before I merge? Thanks!

@jrodewig jrodewig requested a review from romseygeek January 24, 2022 15:36
romseygeek
romseygeek approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor

Thanks @Ekimik @romseygeek

@jrodewig
Copy link
Contributor

@elasticmachine test this please

@jrodewig jrodewig merged commit 1a4fd34 into elastic:7.16 Jan 24, 2022
This was referenced Jan 24, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82954)
c7917d7 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82956)
0813bda 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82955)
91b0356 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82958)
c89964e 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82959)
f882cbf 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82957)
5e01c06 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82960)
832565b 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82961)
c01545e 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

Co-authored-by: Jan Jíša <[email protected]>
This was referenced Jan 24, 2022
Merged
Merged
Merged
@jrodewig
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ master
✅ 8.0
✅ 7.17
✅ 7.15
✅ 7.14
✅ 7.13
✅ 7.12
✅ 7.11
✅ 7.10
✅ 7.9
✅ 6.8

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82962)
0c10b89 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

# Conflicts:
#	docs/reference/analysis/tokenfilters/hunspell-tokenfilter.asciidoc

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82963)
3cb9c2f 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

# Conflicts:
#	docs/reference/analysis/tokenfilters/hunspell-tokenfilter.asciidoc

Co-authored-by: Jan Jíša <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2022
@jrodewig @Ekimik
[DOCS] Remove Hunspell dictionaries location config (#82704) (#82964)
5c6564f 
User can no longer set location for Hunspell dictionaries. `<config-dir>/hunspell` directory is silently used everytime no matter what configuration is used.

Co-authored-by: James Rodewig <[email protected]>
(cherry picked from commit 1a4fd34)

# Conflicts:
#	docs/reference/analysis/tokenfilters/hunspell-tokenfilter.asciidoc

Co-authored-by: Jan Jíša <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

@jrodewig jrodewig Awaiting requested review from jrodewig

Assignees

@jrodewig jrodewig

Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Relevance/Analysis How text is split into tokens Team:Docs Meta label for docs team Team:Search Meta label for search team v6.8.24 v7.9.4 v7.10.3 v7.11.3 v7.12.2 v7.13.5 v7.14.3 v7.15.3 v7.16.4 v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ekimik @elasticmachine @jrodewig @romseygeek @albertzaharovits @jtibshirani @elasticsearchmachine