Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch auto create index cluster state updates #82159

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Batch auto create index cluster state updates #82159

merged 4 commits into from
Jan 11, 2022

Conversation

probakowski
Copy link
Contributor

This change adds batching for cluster state updates to auto create index action. It will do a single reroute at the end of the batch which speeds up the operation

@probakowski probakowski added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 labels Dec 31, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Dec 31, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

original-brownbear
original-brownbear approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but lets add a TODO as requested to make this nicer). For now this is a very nice speedup for our benchmarking.

server/src/main/java/org/elasticsearch/action/admin/indices/create/AutoCreateAction.java Show resolved Hide resolved
@original-brownbear
Copy link
Member

@probakowski let's only do 8.1 here IMO. No need to push this to 8.0, it's not that much user impact to justify the backport.

@probakowski
Copy link
Contributor Author

Thanks @original-brownbear! That makes sense, I'll do master only

@probakowski probakowski added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 11, 2022
@elasticsearchmachine elasticsearchmachine merged commit 0054ec3 into elastic:master Jan 11, 2022
@probakowski probakowski deleted the auto-create-batch2 branch January 11, 2022 12:10
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 11, 2022
@original-brownbear
Defer Reroute When Autocreating Datastream
fc5f4ca 
Defer reroute on autocreate DS. Follow-up to elastic#82159.
@original-brownbear original-brownbear mentioned this pull request Jan 11, 2022
Merged
original-brownbear added a commit that referenced this pull request Jan 11, 2022
@original-brownbear
Defer Reroute When Autocreating Datastream (#82412)
854b9e6 
Defer reroute on autocreate DS. Follow-up to #82159.

relates #77466
@original-brownbear original-brownbear mentioned this pull request Jan 13, 2022
Merged
@joegallo joegallo mentioned this pull request Jan 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@original-brownbear original-brownbear original-brownbear approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@probakowski @elasticmachine @original-brownbear @elasticsearchmachine