Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore errors syncing ephemeral files in test clusters #82154

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Ignore errors syncing ephemeral files in test clusters #82154

merged 1 commit into from
Jan 4, 2022

Conversation

mark-vieira
Copy link
Contributor

#81482 didn't completely fix this underlying issue as FileTreeWalker will throw an exception it seems if a file disappears during traversal. Let's make this more robust and catch this exception and simply ignore if it's complaining about a missing .attach_pid file.

@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Dec 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira mark-vieira merged commit 76b9255 into elastic:master Jan 4, 2022
@mark-vieira mark-vieira deleted the testclusters_sync_fix branch January 4, 2022 17:55
@mark-vieira mark-vieira mentioned this pull request Jan 4, 2022
Merged
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 4, 2022
@mark-vieira
Ignore errors syncing ephemeral files in test clusters (elastic#82154)
f68eff3
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 4, 2022
@mark-vieira
Ignore errors syncing ephemeral files in test clusters (elastic#82154)
822b956
@mark-vieira mark-vieira mentioned this pull request Jan 4, 2022
Merged
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 4, 2022
@mark-vieira
Ignore errors syncing ephemeral files in test clusters (elastic#82154)
e1baf7a
@mark-vieira mark-vieira mentioned this pull request Jan 4, 2022
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.17
✅ 7.16

elasticsearchmachine pushed a commit that referenced this pull request Jan 4, 2022
@mark-vieira
Ignore errors syncing ephemeral files in test clusters (#82154) (#82223)
8684b76
elasticsearchmachine pushed a commit that referenced this pull request Jan 4, 2022
@mark-vieira
Ignore errors syncing ephemeral files in test clusters (#82154) (#82221)
778f542
elasticsearchmachine pushed a commit that referenced this pull request Jan 4, 2022
@mark-vieira
Ignore errors syncing ephemeral files in test clusters (#82154) (#82222)
0854d44
@mark-vieira mark-vieira mentioned this pull request Jan 5, 2022
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (#8…
01d2b78 
…2288)

Third attempt at sorting out this problem after #82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (el…
ad7255f 
…astic#82288)

Third attempt at sorting out this problem after elastic#82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (el…
e8e342b 
…astic#82288)

Third attempt at sorting out this problem after elastic#82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (el…
6331bc0 
…astic#82288)

Third attempt at sorting out this problem after elastic#82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (#8…
48fd48b 
…2288) (#82300)

Third attempt at sorting out this problem after #82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (#8…
6a04929 
…2288) (#82298)

Third attempt at sorting out this problem after #82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
elasticsearchmachine pushed a commit that referenced this pull request Jan 6, 2022
@mark-vieira
Handle wrapped IO exceptions in test cluster distribution syncing (#8…
e488750 
…2288) (#82299)

Third attempt at sorting out this problem after #82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
@mark-vieira @astefan
Ignore errors syncing ephemeral files in test clusters (elastic#82154)
e849a73
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
@mark-vieira @astefan
Handle wrapped IO exceptions in test cluster distribution syncing (el…
4be5386 
…astic#82288)

Third attempt at sorting out this problem after elastic#82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
@mark-vieira @astefan
Ignore errors syncing ephemeral files in test clusters (elastic#82154)
52b467d
astefan pushed a commit to astefan/elasticsearch that referenced this pull request Jan 7, 2022
@mark-vieira @astefan
Handle wrapped IO exceptions in test cluster distribution syncing (el…
a95158b 
…astic#82288)

Third attempt at sorting out this problem after elastic#82154 didn't do the
trick. The issue is that `FileTreeIterator` wraps the root cause
exception in an `UncheckedIOException` so to detect this scenario
properly we actually have to inspect the cause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugnascotia pugnascotia pugnascotia approved these changes

@breskeby breskeby Awaiting requested review from breskeby

Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.16.3 v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mark-vieira @elasticmachine @elasticsearchmachine @pugnascotia