Add explicit "roles.yml" support to testclusters #82137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400
tvernum
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
In #81400 we're changing the privileges of I could put a hack into I've only changed 1 QA test in this PR. Once it's approved I can go through and change all the other tests as well and then we can consider making it an error to set |
4 tasks
mark-vieira
approved these changes
Dec 30, 2021
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Show resolved
Hide resolved
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 5, 2022
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400 Backport of: elastic#82137
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 5, 2022
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: #81400 Backport of: #82137
|
@tvernum can we backport this to 7.17 as well? We want to keep all long term support branches as similar as possible WRT to build infrastructure since it makes our lives considerably easier down the road. |
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 6, 2022
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400 Backport of: elastic#82137
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 6, 2022
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: #81400 Backport of: #82137
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400
astefan
pushed a commit
to astefan/elasticsearch
that referenced
this pull request
Jan 7, 2022
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, within tests, the file "roles.yml" (that is used to define
security roles in a cluster) would need to be configured using
extraConfigFile. This is effective, but means that there can only bea single source of security roles for the testcluster.
This change introduces an explicit "securityRoles" setting in
testclusters that will concatenate the provided files into a single
"roles.yml" in the config directory. This makes it possible for
testclusters itself to define standard roles as well as having each
test define additional roles it may need.
Relates: #81400