-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit "roles.yml" support to testclusters #82137
Conversation
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400
Pinging @elastic/es-delivery (Team:Delivery) |
In #81400 we're changing the privileges of I could put a hack into I've only changed 1 QA test in this PR. Once it's approved I can go through and change all the other tests as well and then we can consider making it an error to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments but otherwise LGTM. Thanks, Tim.
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchCluster.java
Outdated
Show resolved
Hide resolved
build-tools/src/main/java/org/elasticsearch/gradle/testclusters/ElasticsearchNode.java
Show resolved
Hide resolved
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400 Backport of: elastic#82137
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: #81400 Backport of: #82137
@tvernum can we backport this to 7.17 as well? We want to keep all long term support branches as similar as possible WRT to build infrastructure since it makes our lives considerably easier down the road. |
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400 Backport of: elastic#82137
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: #81400 Backport of: #82137
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400
Previously, within tests, the file "roles.yml" (that is used to define security roles in a cluster) would need to be configured using `extraConfigFile`. This is effective, but means that there can only be a single source of security roles for the testcluster. This change introduces an explicit "securityRoles" setting in testclusters that will concatenate the provided files into a single "roles.yml" in the config directory. This makes it possible for testclusters itself to define standard roles as well as having each test define additional roles it may need. Relates: elastic#81400
Previously, within tests, the file "roles.yml" (that is used to define
security roles in a cluster) would need to be configured using
extraConfigFile
. This is effective, but means that there can only bea single source of security roles for the testcluster.
This change introduces an explicit "securityRoles" setting in
testclusters that will concatenate the provided files into a single
"roles.yml" in the config directory. This makes it possible for
testclusters itself to define standard roles as well as having each
test define additional roles it may need.
Relates: #81400