Move API Key related classes into apikey package #82047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API key related classes, including rest actions, request, response, transport actions are scattered in different places. Some of them are in a apikey package. But many of them are not. This PR moves all these classes into the relevant apikey packages.
ywangd
added
>refactoring
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
tvernum
approved these changes
Dec 23, 2021
| @@ -14,6 +14,7 @@ | |||
| import org.elasticsearch.common.io.stream.StreamOutput; | |||
| import org.elasticsearch.common.io.stream.Writeable; | |||
| import org.elasticsearch.common.settings.SecureString; | |||
| import org.elasticsearch.xpack.core.security.action.apikey.CreateApiKeyRequest; | |||
There was a problem hiding this comment.
I think this import is redundant
There was a problem hiding this comment.
You are very right. Spotless caught me as well 🤦
...ava/org/elasticsearch/xpack/core/security/action/apikey/CreateApiKeyRequestBuilderTests.java
Outdated
Show resolved
Hide resolved
.../test/java/org/elasticsearch/xpack/core/security/action/apikey/CreateApiKeyRequestTests.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/elasticsearch/xpack/core/security/action/apikey/GetApiKeyRequestTests.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/elasticsearch/xpack/core/security/action/apikey/GetApiKeyResponseTests.java
Outdated
Show resolved
Hide resolved
...t/java/org/elasticsearch/xpack/core/security/action/apikey/InvalidateApiKeyRequestTests.java
Outdated
Show resolved
Hide resolved
.../java/org/elasticsearch/xpack/core/security/action/apikey/InvalidateApiKeyResponseTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/elasticsearch/xpack/security/action/apikey/TransportGrantApiKeyActionTests.java
Outdated
Show resolved
Hide resolved
|
@elastic/es-security I am going to merge this PR if no objection is raised till next Monday. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API key related classes, including rest actions, request, response,
transport actions are scattered in different places. Some of them are in
a apikey package. But many of them are not. This PR moves all these
classes and associated test classes into the relevant apikey packages.