Add doPrivileged section in deprecation logger #81819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripts using deprecation logger can trigger log files rolling over. Scripts also run with a very limited permissions and without doPrivileged section would cause SM exception closes elastic#81708
pgomulka
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka
commented
Dec 16, 2021
| final LoggerContextFactory originalFactory = LogManager.getFactory(); | ||
| try { | ||
| AtomicBoolean supplierCalled = new AtomicBoolean(false); | ||
| // mocking the logger used inside DeprecationLogger requires heavy hacking... |
There was a problem hiding this comment.
not super proud on how I had to set up that logging configuration but it is not far worse to what we had before https://github.com/elastic/elasticsearch/pull/37281/files#diff-70de5a6ba5c637e7f19c51341417760d6e957beb5a1fa5703049095ea2719ee0R322
|
Hi @pgomulka, I've created a changelog YAML for you. |
…/elasticsearch into revive_deprecation_do_privilege
pgomulka
removed
the
:Core/Infra/Scripting
jdconrad
approved these changes
Dec 16, 2021
pgomulka
added
the
auto-backport
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Dec 17, 2021
Scripts using deprecation logger can trigger log files rolling over. Scripts also run with a very limited permissions and without doPrivileged section would cause SM exception closes elastic#81708
💔 Backport failed
You can use sqren/backport to manually backport by running |
|
@pgomulka the 7.17 branch was created yesterday and it's inconsistent for this to go into 7.16 but not 7.17. I added the v7.17.0 label. Please can you make sure this gets into the 7.17 branch. |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Dec 20, 2021
Scripts using deprecation logger can trigger log files rolling over. Scripts also run with a very limited permissions and without doPrivileged section would cause SM exception closes elastic#81708
pgomulka
added a commit
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripts using deprecation logger can trigger log files rolling over.
Scripts also run with a very limited permissions and without
doPrivileged section would cause SM exception
closes #81708
gradle check?