-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust CacheFileTests.testCacheFileCreatedAsSparseFile #81748
Conversation
Pinging @elastic/es-distributed (Team:Distributed) |
Some background: On aarch64 RHEL and its derivatives (including CentOS, Alma, Rocky) use a 64KB page size and Debian and its derivatives (including Ubuntu) use a 4KB page size. On x86_64 all of these use a 4KB page size. This difference has also affected Kibana - see for example elastic/kibana#89382 (comment) and the other pages linked from there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @droberts195. When I adapted the test for (but I should have checked the docs...) |
Thanks both! |
Yes, I think you're right that Amazon Linux changed the page size on aarch64 compared to the RHEL code - for example vectordotdev/vector#4392 (comment) agrees with you. There are "bug for bug" rebuilds of RHEL, where they don't change anything apart from branding, such as CentOS, Alma and Rocky. And then there are slightly modified rebuilds like Oracle Linux and Amazon Linux where they tweak things a bit. So I guess the page size on aarch64 is one thing Amazon tweaked. |
It looks like some
aarch64
architectures have a non4KB
block size but the test expects that only encryption at rest tests use a non default block size. This change removes the check on EAR.Sorry @DaveCTurner for the iterations required to adjust this test :( I hope that the assertions for non 4KB block size will work everywhere now but we'll have to wait for ARM tests to execute to be 100% sure.
Relates #81362 (comment)