Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CacheFileTests.testCacheFileCreatedAsSparseFile #81748

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Dec 15, 2021

It looks like some aarch64 architectures have a non 4KB block size but the test expects that only encryption at rest tests use a non default block size. This change removes the check on EAR.

Sorry @DaveCTurner for the iterations required to adjust this test :( I hope that the assertions for non 4KB block size will work everywhere now but we'll have to wait for ARM tests to execute to be 100% sure.

Relates #81362 (comment)

@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.1.0 labels Dec 15, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Dec 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@droberts195
Copy link
Contributor

It looks like some aarch64 architectures have a non 4KB block size

Some background:

On aarch64 RHEL and its derivatives (including CentOS, Alma, Rocky) use a 64KB page size and Debian and its derivatives (including Ubuntu) use a 4KB page size. On x86_64 all of these use a 4KB page size.

This difference has also affected Kibana - see for example elastic/kibana#89382 (comment) and the other pages linked from there.

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx
Copy link
Member Author

tlrx commented Dec 15, 2021

Thanks @droberts195. When I adapted the test for aarch64 I wasn't able to test on ARM architectures with CentOS so I picked up Amazon Linux 2 instead, which I thought was derived from RHEL.

(but I should have checked the docs...)

@tlrx tlrx merged commit d2ef578 into elastic:master Dec 15, 2021
@tlrx tlrx deleted the adjust-cachefiletest branch December 15, 2021 10:04
@tlrx
Copy link
Member Author

tlrx commented Dec 15, 2021

Thanks both!

@droberts195
Copy link
Contributor

When I adapted the test for aarch64 I wasn't able to test on ARM architectures with CentOS so I picked up Amazon Linux 2 instead, which I thought was derived from RHEL.

Yes, I think you're right that Amazon Linux changed the page size on aarch64 compared to the RHEL code - for example vectordotdev/vector#4392 (comment) agrees with you.

There are "bug for bug" rebuilds of RHEL, where they don't change anything apart from branding, such as CentOS, Alma and Rocky. And then there are slightly modified rebuilds like Oracle Linux and Amazon Linux where they tweak things a bit. So I guess the page size on aarch64 is one thing Amazon tweaked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants