Move MapMatcher into ES #81593
Merged
Move MapMatcher into ES #81593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
This donates the `MapMatcher` project to Elasticsearch. We want it in our code base so we can more easilly maintain it and don't have to wait for a release. It really isn't used outside of Elasticsearch so it isn't really useful to keep it separate. We considered removing it entirely it but still think that it's mostly and improvement on `NotEqualMessageBuilder` and the build in `equalTo`.
jpountz
approved these changes
Dec 9, 2021
nik9000
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This donates the
MapMatcherproject to Elasticsearch. We want it inour code base so we can more easilly maintain it and don't have to wait
for a release. It really isn't used outside of Elasticsearch so it isn't
really useful to keep it separate.
We considered removing it entirely it but still think that it's mostly
and improvement on
NotEqualMessageBuilderand the build inequalTo.