-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_tier_preference docs changes for 8.0 #81389
Conversation
and rewrite the page slightly -- there's only _tier_preference so we don't have to talk about 'settings' or 'attributes', it's just the one.
So reword this section to more strongly indicate that you'll need to disable it if you don't want it -- it's not enough to 'merely' specify some manual allocation.
'also' made more sense before the preceding paragraph was removed.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left one really minor comment that is optional.
docs/reference/datatiers.asciidoc
Outdated
@@ -127,5 +122,6 @@ If you set the tier preference to `null`, {es} ignores the data tier roles durin | |||
{ilm-init} automatically transitions managed | |||
indices through the available data tiers using the <<ilm-migrate, migrate>> action. | |||
By default, this action is automatically injected in every phase. | |||
You can explicitly specify the migrate action to override the default behavior, | |||
or use the <<ilm-allocate, allocate action>> to manually specify allocation rules. | |||
You can explicitly specify the migrate action to disable automatic migration, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be useful to say "specify the migrate action with 'enabled': false", because just manually specifying the migrate action doesn't actually disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do! I was already on the fence about exactly that, so thanks for giving me a reason to choose one way over the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #76147 and particularly #79751
Remove some places that mention setting the
_tier_preference
tonull
, as well as conditionals around the injection of themigrate
action -- on 8.0, newly created indices will always get either an explicitly-set or defaulted_tier_preference
, and themigrate
action is always inserted.Also fixes some vestigial documentation that still references the
_tier
filters which had already been removed from 8.0 (see #73074).