Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_tier_preference docs changes for 8.0 #81389

Merged
merged 6 commits into from
Dec 7, 2021

Conversation

joegallo
Copy link
Contributor

@joegallo joegallo commented Dec 6, 2021

Related to #76147 and particularly #79751

Remove some places that mention setting the _tier_preference to null, as well as conditionals around the injection of the migrate action -- on 8.0, newly created indices will always get either an explicitly-set or defaulted _tier_preference, and the migrate action is always inserted.

Also fixes some vestigial documentation that still references the _tier filters which had already been removed from 8.0 (see #73074).

and rewrite the page slightly -- there's only _tier_preference so we
don't have to talk about 'settings' or 'attributes', it's just the
one.
So reword this section to more strongly indicate that you'll need to
disable it if you don't want it -- it's not enough to 'merely' specify
some manual allocation.
@joegallo joegallo added v8.0.0 v8.1.0 :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Dec 6, 2021
'also' made more sense before the preceding paragraph was removed.
@joegallo joegallo added the >docs General docs changes label Dec 6, 2021
@joegallo joegallo marked this pull request as ready for review December 6, 2021 21:18
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Dec 6, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@joegallo joegallo requested a review from dakrone December 6, 2021 21:18
@joegallo joegallo added >non-issue and removed >docs General docs changes Team:Docs Meta label for docs team labels Dec 6, 2021
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left one really minor comment that is optional.

@@ -127,5 +122,6 @@ If you set the tier preference to `null`, {es} ignores the data tier roles durin
{ilm-init} automatically transitions managed
indices through the available data tiers using the <<ilm-migrate, migrate>> action.
By default, this action is automatically injected in every phase.
You can explicitly specify the migrate action to override the default behavior,
or use the <<ilm-allocate, allocate action>> to manually specify allocation rules.
You can explicitly specify the migrate action to disable automatic migration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be useful to say "specify the migrate action with 'enabled': false", because just manually specifying the migrate action doesn't actually disable it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do! I was already on the fence about exactly that, so thanks for giving me a reason to choose one way over the other.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joegallo joegallo merged commit 0db66b8 into elastic:master Dec 7, 2021
@joegallo joegallo deleted the tier-preference-docs-8.0 branch December 7, 2021 00:40
joegallo added a commit that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue Team:Data Management Meta label for data/management team v8.0.0-rc2 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants