Fix Serialization version check in Shutdown Status #81342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version used to determine whether we should serialize the allocation decisions as part of the Shutdown Status response was not updated after elastic#78727 was merged. This causes very confusing errors in mixed 8.x/7.16.x clusters. Note: The version constant was updated in the backport to 7.16, but not in 8.x. This is good, as at time of writing, 7.16 has shipped, but 8.0 has not.
gwbrown
added
>non-issue
v8.0.0
:Core/Infra/Node Lifecycle
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@pgomulka I ran the upgrade test several times locally with this patch and didn't see any failures - this is a great example of why we need those tests! Let me know if this doesn't solve the issues you're seeing. |
gwbrown
added
the
auto-merge-without-approval
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Dec 3, 2021
The version used to determine whether we should serialize the allocation decisions as part of the Shutdown Status response was not updated after elastic#78727 was merged. This causes very confusing errors in mixed 8.x/7.16.x clusters. Note: The version constant was updated in the backport to 7.16, but not in 8.x. This is good, as at time of writing, 7.16 has shipped, but 8.0 has not.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 4, 2021
The version used to determine whether we should serialize the allocation decisions as part of the Shutdown Status response was not updated after #78727 was merged. This causes very confusing errors in mixed 8.x/7.16.x clusters. Note: The version constant was updated in the backport to 7.16, but not in 8.x. This is good, as at time of writing, 7.16 has shipped, but 8.0 has not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version used to determine whether we should serialize the
allocation decisions as part of the Shutdown Status response
was not updated after #78727 was merged. This causes very
confusing errors in mixed 8.x/7.16.x clusters.
Note: The version constant was updated in the backport to 7.16,
but not in 8.x. This is good, as at time of writing, 7.16 has
shipped, but 8.0 has not.