Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDB: move TimeSeriesModeIT to yaml tests #80933

Merged
merged 6 commits into from
Nov 23, 2021
Merged

TSDB: move TimeSeriesModeIT to yaml tests #80933

merged 6 commits into from
Nov 23, 2021

Conversation

weizijun
Copy link
Contributor

I move TimeSeriesModeIT to yaml tests.
I move the below lists to 15_timestamp_mapping.yml:

testTimestampMillis -> date
testTimestampNanos -> date_nanos
testAddsTimestamp -> automatically add with date
testBadTimestamp  -> reject @timestamp with wrong type
testDisabledTimeStampMapper -> reject timestamp meta field with wrong type

And add some tests in 15_timestamp_mapping.yml:

testBadTimeStampMapper  -> reject bad timestamp meta field
testWithoutTimestamp -> write without timestamp
testAddTimeStampMeta -> add timestamp meta
testEnabledTimeStampMapper -> enable timestamp meta field

AND move the below lists to 10_settings.yml:

testEnableTimestampRange ->  set start_time and end_time

And add some tests in 10_settings.yml:

testBadStartTime\testBadEndTime ->  set bad start_time and end_time

@elasticsearchmachine elasticsearchmachine added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.1.0 labels Nov 23, 2021
@weizijun
Merge branch 'upstream/master' into move-tsdb-IT-to-yaml
0c1c7cd 
* upstream/master:
  Cleanup SLM History Item .equals (elastic#80938)
  Rework breaking changes for new structure (elastic#80907)
  [DOCS] Fix elasticsearch-reset-password typo (elastic#80919)
  [ML] No need to use parent task client when internal infer delegates (elastic#80905)
  Fix shadowed vars pt6 (elastic#80899)
  add ignore info (elastic#80924)
  Fix several potential circuit breaker leaks in Aggregators (elastic#79676)

# Conflicts:
#	server/src/internalClusterTest/java/org/elasticsearch/index/TimeSeriesModeIT.java
nik9000
nik9000 reviewed Nov 23, 2021
View reviewed changes
.idea/inspectionProfiles/Project_Default.xml Outdated Show resolved Hide resolved
build-tools-internal/version.properties Outdated Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/10_settings.yml Outdated Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/15_timestamp_mapping.yml Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/15_timestamp_mapping.yml Outdated Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/15_timestamp_mapping.yml Outdated Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/15_timestamp_mapping.yml Outdated Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/15_timestamp_mapping.yml Outdated Show resolved Hide resolved
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/10_settings.yml Show resolved Hide resolved
@weizijun
revert
e5c2989
@weizijun
format
11fad5f
@weizijun
Merge branch 'upstream/master' into move-tsdb-IT-to-yaml
0f15c86 
* upstream/master:
  Remove obsolete typed legacy index templates (elastic#80937)
  Remove unnecessary shuffle in unassigned shards allocation. (elastic#65172)
  TSDB: Tests for nanosecond timeprecision timestamp just beyond the limit (elastic#80932)

# Conflicts:
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/10_settings.yml
@weizijun
revert
1ef4e66
@nik9000
Copy link
Member

nik9000 commented Nov 23, 2021

@elasticmachine test this please

@nik9000 nik9000 merged commit a6d5899 into elastic:master Nov 23, 2021
@nik9000 nik9000 added the :StorageEngine/TSDB You know, for Metrics label Nov 23, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000 nik9000 mentioned this pull request Nov 23, 2021
Closed
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Nov 24, 2021
@weizijun
Merge branch 'upstream/master' into tsdb-required-range-settings
21b60b5 
* upstream/master: (29 commits)
  Fix typo (elastic#80925)
  Increase docker compose timeouts for CI builds
  TSDB: fix error without feature flag (elastic#80945)
  [DOCS] Relocate `index.mapping.dimension_fields.limit` setting docs (elastic#80964)
  Explicit write methods for always-missing values (elastic#80958)
  TSDB: move TimeSeriesModeIT to yaml tests (elastic#80933)
  [ML] Removing temporary debug (elastic#80956)
  Remove unused ConnectTransportException#node (elastic#80944)
  Reinterpret dots in field names as object structure (elastic#79922)
  Remove obsolete typed legacy index templates (elastic#80937)
  Remove unnecessary shuffle in unassigned shards allocation. (elastic#65172)
  TSDB: Tests for nanosecond timeprecision timestamp just beyond the limit (elastic#80932)
  Cleanup SLM History Item .equals (elastic#80938)
  Rework breaking changes for new structure (elastic#80907)
  [DOCS] Fix elasticsearch-reset-password typo (elastic#80919)
  [ML] No need to use parent task client when internal infer delegates (elastic#80905)
  Fix shadowed vars pt6 (elastic#80899)
  add ignore info (elastic#80924)
  Fix several potential circuit breaker leaks in Aggregators (elastic#79676)
  Extract more standard metadata from binary files (elastic#78754)
  ...
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Nov 24, 2021
@weizijun
Merge branch 'upstream/master' into update-filter-improve
8507e30 
* upstream/master: (319 commits)
  Fix typo (elastic#80925)
  Increase docker compose timeouts for CI builds
  TSDB: fix error without feature flag (elastic#80945)
  [DOCS] Relocate `index.mapping.dimension_fields.limit` setting docs (elastic#80964)
  Explicit write methods for always-missing values (elastic#80958)
  TSDB: move TimeSeriesModeIT to yaml tests (elastic#80933)
  [ML] Removing temporary debug (elastic#80956)
  Remove unused ConnectTransportException#node (elastic#80944)
  Reinterpret dots in field names as object structure (elastic#79922)
  Remove obsolete typed legacy index templates (elastic#80937)
  Remove unnecessary shuffle in unassigned shards allocation. (elastic#65172)
  TSDB: Tests for nanosecond timeprecision timestamp just beyond the limit (elastic#80932)
  Cleanup SLM History Item .equals (elastic#80938)
  Rework breaking changes for new structure (elastic#80907)
  [DOCS] Fix elasticsearch-reset-password typo (elastic#80919)
  [ML] No need to use parent task client when internal infer delegates (elastic#80905)
  Fix shadowed vars pt6 (elastic#80899)
  add ignore info (elastic#80924)
  Fix several potential circuit breaker leaks in Aggregators (elastic#79676)
  Extract more standard metadata from binary files (elastic#78754)
  ...
@pugnascotia pugnascotia added the >test Issues or PRs that are addressing/adding tests label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weizijun @nik9000 @elasticmachine @pugnascotia @elasticsearchmachine