Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Return 200 OK response code for a cluster health timeout (#78968)" #80821

Merged

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Nov 18, 2021

This reverts following PRs:

@arteam arteam changed the title Revert "Return 200 OK response code for a cluster health timeout (#7968)" Revert "Return 200 OK response code for a cluster health timeout (#78968)" Nov 18, 2021
@arteam arteam marked this pull request as draft November 18, 2021 12:14
@arteam arteam force-pushed the revert-200-ok-response-code-cluster-health branch from ea4258e to 8e281f9 Compare November 18, 2021 13:47
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
@arteam arteam mentioned this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
#80821 reverts a breaking change
arteam added a commit that referenced this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
#80821 reverts a breaking change
@arteam arteam added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue labels Nov 18, 2021
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 18, 2021
arteam added a commit that referenced this pull request Nov 18, 2021
#78968)" (#80826)

* [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)"

This reverts commit a2c3dae

* Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)"

This reverts commit 4102cf7.

* Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)"

This reverts commit b9fbe66.

* Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)"

This reverts commit f60bda5.

* Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)"

This reverts commit 8901a99

* Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)"

This reverts commit f266eb3

* Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)

This reverts commit fa4d562.

* Revert "[8.0] Disable BWC for #80821 (#80840)"
@arteam
Copy link
Contributor Author

arteam commented Nov 18, 2021

@elasticmachine update branch

@arteam
Copy link
Contributor Author

arteam commented Nov 18, 2021

@elasticmachine run elasticsearch-ci/part-1

@arteam arteam marked this pull request as ready for review November 18, 2021 18:40
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if/when CI passes).

@arteam
Copy link
Contributor Author

arteam commented Nov 18, 2021

Thanks Henning!

@arteam arteam merged commit 89bbac9 into elastic:master Nov 18, 2021
@arteam arteam deleted the revert-200-ok-response-code-cluster-health branch November 18, 2021 18:55
arteam added a commit that referenced this pull request Nov 19, 2021
arteam added a commit to arteam/elasticsearch that referenced this pull request Nov 19, 2021
arteam added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants