-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Return 200 OK response code for a cluster health timeout (#78968)" #80821
Merged
arteam
merged 11 commits into
elastic:master
from
arteam:revert-200-ok-response-code-cluster-health
Nov 18, 2021
Merged
Revert "Return 200 OK response code for a cluster health timeout (#78968)" #80821
arteam
merged 11 commits into
elastic:master
from
arteam:revert-200-ok-response-code-cluster-health
Nov 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic#78968)" This reverts commit a2c3dae
arteam
changed the title
Revert "Return 200 OK response code for a cluster health timeout (#7968)"
Revert "Return 200 OK response code for a cluster health timeout (#78968)"
Nov 18, 2021
…th_timeout parameter (elastic#80178)" This reverts commit 1c711e3.
…ut field (elastic#79436)" This reverts commit f60bda5.
…r new cluster health response code (elastic#79351)" This reverts commit 8901a99
…lth` (elastic#78180)" This reverts commit f266eb3
arteam
force-pushed
the
revert-200-ok-response-code-cluster-health
branch
from
November 18, 2021 13:47
ea4258e
to
8e281f9
Compare
This reverts commit fa4d562
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
#80821 reverts a breaking change
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
arteam
added
:Distributed Indexing/CRUD
A catch all label for issues around indexing, updating and getting a doc by id. Not search.
>non-issue
labels
Nov 18, 2021
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
This reverts commit 306aded.
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
#78968)" (#80826) * [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)" This reverts commit 4102cf7. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562. * Revert "[8.0] Disable BWC for #80821 (#80840)"
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/part-1 |
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Nov 18, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (if/when CI passes).
Thanks Henning! |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 19, 2021
…m 8.0.0 release notes (elastic#80852) It was reverted in elastic#80821
9 tasks
This was referenced Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/CRUD
A catch all label for issues around indexing, updating and getting a doc by id. Not search.
>non-issue
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts following PRs:
_cluster/health
(Deprecate returning 408 for a server timeout on_cluster/health
#78180)"return_200_for_cluster_health_timeout
parameter #80178)"