Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fixes query parameters for get buckets API #80643

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 10, 2021

Relates to elastic/elasticsearch-specification#1020

This PR fixes the documentation for the machine learning "get buckets" API, since it was missing a query parameters section. It also removes influencer_field_value from the response body, since that property does not appear in my test results.

Preview

https://elasticsearch_80643.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/ml-get-bucket.html

@lcawl lcawl added >docs General docs changes :ml Machine learning v8.0.0 v7.16.0 v8.1.0 labels Nov 10, 2021
@elasticmachine elasticmachine added Team:ML Meta label for the ML team Team:Docs Meta label for docs team labels Nov 10, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lcawl lcawl requested a review from droberts195 November 22, 2021 16:50
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl added the auto-backport Automatically create backport pull requests when merged label Nov 22, 2021
@lcawl lcawl merged commit 38cbd11 into elastic:master Nov 22, 2021
@lcawl lcawl deleted the ml-query-params branch November 22, 2021 19:34
lcawl added a commit to lcawl/elasticsearch that referenced this pull request Nov 22, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.0
7.16 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 80643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v7.16.0 v8.0.0-rc1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants