[8.0] [ML] Need to tolerate .ml-config being an alias (#80025) #80036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .ml-config index was introduced in 6.x, and hence may be reindexed by the system index upgrade code in 7.16. This in turn means that all our use of the name .ml-config must tolerate it either being a concrete index or an alias to some other index that's been created as a replacement for the original 6.x index. We were mostly compliant with this need. The only place where we weren't was in the code for config migration from cluster state. It's likely that any cluster running 7.16 would already have had configs migrated out of cluster state. The only way this couldn't be the case is if the cluster was upgraded from 6.x to 7.16 in a full cluster restart. Any rolling upgrade would have had to go via 6.8 where config migration could have taken place. But still, it's best that the patterns in the code reflect best practice for the future, as .ml-config will need to be reindexed again as the years go by.
droberts195
added
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.0: