Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scriptfield test: set number of shards to 1 (#80026) #80032

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

stu-elastic
Copy link
Contributor

The 20_scriptfield:"Scripted Field with error accessing an
unsupported field via the script fields api" test expects to fail because
the field is not yet supported in the fields API.

However, if the number of shards in the target index is randomly more
than one, the empty shard will succeed leading to a 200 response rather
than the expected 400 response.

This change forces the number of shards to 1 to avoid this scenario.

Fixes: #79986
Backport: 9511c54

The 20_scriptfield:"Scripted Field with error accessing an
unsupported field via the script fields api" test expects to fail because
the field is not yet supported in the fields API.

However, if the number of shards in the target index is randomly more
than one, the empty shard will succeed leading to a 200 response rather
than the expected 400 response.

This change forces the number of shards to 1 to avoid this scenario.

Fixes: elastic#79986
Backport: 9511c54
@stu-elastic stu-elastic added >test Issues or PRs that are addressing/adding tests :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache backport v8.0.0 labels Oct 28, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@stu-elastic stu-elastic merged commit 28d0446 into elastic:8.0 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants