Preventing unnecessary ILM policy deletions that drastically slow down SmokeTestMultiNodeClientYamlTestSuiteIT #79946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n SmokeTestMultiNodeClientYamlTestSuiteIT
masseyke
added
:Data Management/ILM+SLM
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Pinging @elastic/clients-team (Team:Clients) |
|
@elasticmachine run elasticsearch-ci/part-1 |
|
@elasticmachine run elasticsearch-ci/part-2 |
|
@elasticmachine run elasticsearch-ci/part-2 |
|
@elasticmachine update branch |
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 28, 2021
…n SmokeTestMultiNodeClientYamlTestSuiteIT (elastic#79946) In elastic#76791 several new default ILM policies were added. EsRestTestCase deletes all ILM policies that it does not know about one-at-a-time. Each of these deletions causes a cluster state change that needs to be propagated to all nodes. In a large test on a multi-node cluster (like SmokeTestMultiNodeClientYamlTestSuiteIT) this eats up a significant amount of time -- about 30% of the runtime of the test. This was causing SmokeTestMultiNodeClientYamlTestSuiteIT to fail with timeouts. This commit adds the new standard ILM policies to the list of known policies not to delete. Closes elastic#77025 Relates elastic#76791
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Oct 28, 2021
…n SmokeTestMultiNodeClientYamlTestSuiteIT (elastic#79946) In elastic#76791 several new default ILM policies were added. EsRestTestCase deletes all ILM policies that it does not know about one-at-a-time. Each of these deletions causes a cluster state change that needs to be propagated to all nodes. In a large test on a multi-node cluster (like SmokeTestMultiNodeClientYamlTestSuiteIT) this eats up a significant amount of time -- about 30% of the runtime of the test. This was causing SmokeTestMultiNodeClientYamlTestSuiteIT to fail with timeouts. This commit adds the new standard ILM policies to the list of known policies not to delete. Closes elastic#77025 Relates elastic#76791
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2021
…n SmokeTestMultiNodeClientYamlTestSuiteIT (#79946) (#80052) In #76791 several new default ILM policies were added. EsRestTestCase deletes all ILM policies that it does not know about one-at-a-time. Each of these deletions causes a cluster state change that needs to be propagated to all nodes. In a large test on a multi-node cluster (like SmokeTestMultiNodeClientYamlTestSuiteIT) this eats up a significant amount of time -- about 30% of the runtime of the test. This was causing SmokeTestMultiNodeClientYamlTestSuiteIT to fail with timeouts. This commit adds the new standard ILM policies to the list of known policies not to delete. Closes #77025 Relates #76791
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 29, 2021
…low down SmokeTestMultiNodeClientYamlTestSuiteIT (#79946) (#80053) * Preventing unnecessary ILM policy deletions that drastically slow down SmokeTestMultiNodeClientYamlTestSuiteIT (#79946) In #76791 several new default ILM policies were added. EsRestTestCase deletes all ILM policies that it does not know about one-at-a-time. Each of these deletions causes a cluster state change that needs to be propagated to all nodes. In a large test on a multi-node cluster (like SmokeTestMultiNodeClientYamlTestSuiteIT) this eats up a significant amount of time -- about 30% of the runtime of the test. This was causing SmokeTestMultiNodeClientYamlTestSuiteIT to fail with timeouts. This commit adds the new standard ILM policies to the list of known policies not to delete. Closes #77025 Relates #76791 * fixing backported code for 7.16 * allowing type removal warnings
This was referenced Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #76791 several new default ILM policies were added. EsRestTestCase deletes all ILM policies that it does
not know about one-at-a-time. Each of these deletions causes a cluster state change that needs to be propagated
to all nodes. In a large test on a multi-node cluster (like SmokeTestMultiNodeClientYamlTestSuiteIT) this eats up a
significant amount of time -- about 30% of the runtime of the test. This was causing
SmokeTestMultiNodeClientYamlTestSuiteIT to fail with timeouts. This commit adds the new standard ILM policies to
the list of known policies not to delete.
Closes #77025
Relates #76791