Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] ILM: Add ESS/ECE instructions for migrating to node roles #79742

Merged
merged 21 commits into from
Oct 28, 2021
Merged

[DOCS] ILM: Add ESS/ECE instructions for migrating to node roles #79742

merged 21 commits into from
Oct 28, 2021

Conversation

DanRoscigno
Copy link
Contributor

@DanRoscigno DanRoscigno commented Oct 25, 2021

This PR adds documentation informing the reader about how the Elasticsearch Service / Elastic Cloud Enterprise upgrade process and autoscaling system automate the migration of the Elasticsearch nodes and ILM policies to using node.roles rather than filtering on node attributes.

Upgrading from Stack 7.7 to 7.15 in both Elasticsearch Service and Elastic Cloud Enterprise was tested, both with and without allowing the upgrade to automatically migrate to node roles. Both environments were also tested with and without autoscaling. Finally, a non-default index template which included the use of node attributes was tested with @stefnestor . All of the test scenarios passed.

Here is a screenshot highlighting the changes (updated with feedback from Deb and Mario):
image

@elasticsearchmachine elasticsearchmachine added v8.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 25, 2021
@DanRoscigno
Copy link
Contributor Author

@DanRoscigno
Copy link
Contributor Author

@DanRoscigno DanRoscigno self-assigned this Oct 25, 2021
@DanRoscigno DanRoscigno added :Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes labels Oct 25, 2021
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Oct 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Left some editorial suggestions.

@DanRoscigno
Copy link
Contributor Author

Feedback from @mduarte :

For version <= 7.10 and < 7.14

Adding a warm, cold or frozen tier, as well as enabling autocaling will migrate the deployment from node_type to node_roles.

For versions >= 7.14

All of the above is true, plus:

It also migrates to node_roles on upgrade to a version >= 7.14
Any new plan change will automatically update the ILM policies from using node_attributes to tier_preference

@DanRoscigno
Copy link
Contributor Author

I committed the feedback from @debadair above, and feedback from @mduarte provided in the related issue. The screenshot in the opening comment is updated.

@jrodewig jrodewig changed the title [DOCS] ILM: Add ESS/ECE simplified instructions for migrating to node roles [DOCS] ILM: Add ESS/ECE instructions for migrating to node roles Oct 28, 2021
@DanRoscigno DanRoscigno removed the request for review from mduarte October 28, 2021 18:17
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanRoscigno. This LGTM.

I left Deb's suggestions as is with the exception of a minor typo. Aside from that typo, the other comments and suggestions are non-blocking. Feel free to disregard them if wanted.

Let me know when you're ready to publish this. I can handle the merge + backports for you.

DanRoscigno and others added 6 commits October 28, 2021 15:09
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
@DanRoscigno
Copy link
Contributor Author

@jrodewig can you give me more info on adding a lead-in sentence to the self managed section (the unresolved comment up above). Here is a new screenshot from a build:
image

@jrodewig
Copy link
Contributor

Hey @DanRoscigno! This looks good.

By "lead-in sentence" I meant "To switch to using node roles:", and you've already re-added that.
I'm ready to merge this if you are.

@jrodewig jrodewig merged commit 73f7827 into elastic:master Oct 28, 2021
@DanRoscigno DanRoscigno deleted the simplified-cloud-instructions branch October 28, 2021 20:38
elasticsearchmachine pushed a commit that referenced this pull request Oct 28, 2021
) (#80045)

Adds documentation informing the reader about how the Elasticsearch Service / Elastic Cloud Enterprise upgrade process and autoscaling system automate the migration of the Elasticsearch nodes and ILM policies to using node.roles rather than filtering on node attributes.

Co-authored-by: debadair <[email protected]>
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Dan Roscigno <[email protected]>
Co-authored-by: debadair <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 28, 2021
) (#80047)

Adds documentation informing the reader about how the Elasticsearch Service / Elastic Cloud Enterprise upgrade process and autoscaling system automate the migration of the Elasticsearch nodes and ILM policies to using node.roles rather than filtering on node attributes.

Co-authored-by: debadair <[email protected]>
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Dan Roscigno <[email protected]>
Co-authored-by: debadair <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Oct 28, 2021
) (#80046)

Adds documentation informing the reader about how the Elasticsearch Service / Elastic Cloud Enterprise upgrade process and autoscaling system automate the migration of the Elasticsearch nodes and ILM policies to using node.roles rather than filtering on node attributes.

Co-authored-by: debadair <[email protected]>
Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Dan Roscigno <[email protected]>
Co-authored-by: debadair <[email protected]>
@danhermann danhermann added v7.16.0 and removed v7.16.1 labels Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.15.2 v7.16.0 v8.0.0-beta1 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants