[Transform] Improve transform upgrader #79601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
force-pushed
the
transform-upgrade-enhancements
branch
from
ad624b0 to
4d23596
Compare
added 5 commits
October 21, 2021 15:22
action.destructive_requires_name is set to true(default)
hendrikmuhs
force-pushed
the
transform-upgrade-enhancements
branch
from
4d23596 to
17c6b4e
Compare
|
Pinging @elastic/ml-core (Team:ML) |
lcawl
reviewed
Oct 21, 2021
.../plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/TransformDeprecations.java
Outdated
Show resolved
Hide resolved
lcawl
reviewed
Oct 21, 2021
...in/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformConfig.java
Outdated
Show resolved
Hide resolved
lcawl
reviewed
Oct 21, 2021
...re/src/test/java/org/elasticsearch/xpack/core/transform/transforms/TransformConfigTests.java
Outdated
Show resolved
Hide resolved
lcawl
approved these changes
Oct 21, 2021
lcawl
reviewed
Oct 21, 2021
.../plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/TransformDeprecations.java
Outdated
Show resolved
Hide resolved
lcawl
added a commit
to lcawl/elasticsearch
that referenced
this pull request
Oct 21, 2021
If you implement my suggestion ( |
…transform/TransformDeprecations.java Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]>
|
@elasticmachine update branch |
added 2 commits
October 25, 2021 09:53
…hs/elasticsearch into transform-upgrade-enhancements
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Oct 25, 2021
This changes fixes some issues with the upgrader. It inlines the index name resolver as wildcard deletes are not supported if action.destructive_requires_name is set to true(default). It changes response to always return all counters in order to avoid an empty response. After documentation has been created, it switches the deprecation URL to the upgrade API docs.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 25, 2021
* [Transform] Improve transform upgrader (#79601) This changes fixes some issues with the upgrader. It inlines the index name resolver as wildcard deletes are not supported if action.destructive_requires_name is set to true(default). It changes response to always return all counters in order to avoid an empty response. After documentation has been created, it switches the deprecation URL to the upgrade API docs. * change url to 7.16 specific one * fix 7.x specific test * fix put mapping call
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 28, 2021
This changes fixes some issues with the upgrader. It inlines the index name resolver as wildcard deletes are not supported if action.destructive_requires_name is set to true(default). It changes response to always return all counters in order to avoid an empty response. After documentation has been created, it switches the deprecation URL to the upgrade API docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes some issues with the upgrader. It inlines the index name resolver as wildcard deletes are not supported if
action.destructive_requires_nameis set totrue(default). It changes response to always return all counters in order to avoid an empty response. After documentation has been created, it switches the deprecation URL to the upgrade API docs.Notes