Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-level field caps requests #79212

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Oct 15, 2021

This PR was reviewed already.

Currently to gather field caps, the coordinator sends a separate transport
request per index. When the original request targets many indices, the overhead
of all these sub-requests can add up and hurt performance. This PR switches the
execution strategy to reduce the number of transport requests: it groups
together the index requests that target the same node, then sends only one
request to each node.

Co-authored-by: Julie Tibshirani [email protected]

Relates #77047
Relates #78647

Closes #74648

Currently to gather field caps, the coordinator sends a separate transport
request per index. When the original request targets many indices, the overhead
of all these sub-requests can add up and hurt performance. This PR switches the
execution strategy to reduce the number of transport requests: it groups
together the index requests that target the same node, then sends only one
request to each node.

Co-authored-by: Julie Tibshirani <[email protected]>
@dnhatn dnhatn marked this pull request as ready for review October 15, 2021 13:24
@dnhatn dnhatn added v7.16.0 :Search/Search Search-related issues that do not fall into other categories labels Oct 15, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn added >enhancement and removed Team:Search Meta label for search team labels Oct 15, 2021
@dnhatn dnhatn merged commit a94f058 into elastic:master Oct 15, 2021
@dnhatn dnhatn deleted the node-level-field-caps branch October 15, 2021 13:25
dnhatn added a commit that referenced this pull request Oct 17, 2021
dnhatn added a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement release highlight :Search/Search Search-related issues that do not fall into other categories v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group shard request per node in the field capabilities API
5 participants