-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Migration information about ES logging breaking changes #79146
[DOCS] Migration information about ES logging breaking changes #79146
Conversation
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this in @pgomulka. I think we can add some more actionable detail to the change so users can update their application. Let me know what you think.
@@ -40,6 +40,7 @@ coming[8.0.0] | |||
* <<breaking_80_threadpool_changes>> | |||
* <<breaking_80_transport_changes>> | |||
* <<breaking_80_watcher_changes>> | |||
* <<breaking_80_logging_changes>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be in alphabetical order.
@@ -144,6 +145,7 @@ include::migrate_8_0/threadpool.asciidoc[] | |||
include::migrate_8_0/transport.asciidoc[] | |||
include::migrate_8_0/watcher.asciidoc[] | |||
include::migrate_8_0/migrate_to_java_time.asciidoc[] | |||
include::migrate_8_0/logging.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should also be in alphabetical order (except for the Java time migration guide).
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Co-authored-by: James Rodewig <[email protected]>
…/elasticsearch into doc/migration_guide_logging_ecs
@jrodewig I also added information about plaintext files removal - a breaking change too. It was done in the same PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor suggestions for the new breaking change.
We also need to add some notable highlights for the ECS change. I left a related comment.
Thanks @pgomulka!
Co-authored-by: James Rodewig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if we incorporate the suggestion we discussed offline. Thanks @pgomulka!
Co-authored-by: James Rodewig <[email protected]>
Adds breaking change docs for #47105. (ECS layout and plaintext log files removal)
Relates to #46119.