Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Migration information about ES logging breaking changes #79146

Merged
merged 8 commits into from
Oct 20, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Oct 14, 2021

Adds breaking change docs for #47105. (ECS layout and plaintext log files removal)

Relates to #46119.

@pgomulka pgomulka added the >docs General docs changes label Oct 14, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Oct 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@pgomulka pgomulka changed the title Add information about JSON logs being ECS compliant Add information to migration guide about JSON logs being ECS compliant Oct 14, 2021
@pgomulka pgomulka requested a review from jrodewig October 15, 2021 14:09
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this in @pgomulka. I think we can add some more actionable detail to the change so users can update their application. Let me know what you think.

@@ -40,6 +40,7 @@ coming[8.0.0]
* <<breaking_80_threadpool_changes>>
* <<breaking_80_transport_changes>>
* <<breaking_80_watcher_changes>>
* <<breaking_80_logging_changes>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be in alphabetical order.

@@ -144,6 +145,7 @@ include::migrate_8_0/threadpool.asciidoc[]
include::migrate_8_0/transport.asciidoc[]
include::migrate_8_0/watcher.asciidoc[]
include::migrate_8_0/migrate_to_java_time.asciidoc[]
include::migrate_8_0/logging.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also be in alphabetical order (except for the Java time migration guide).

docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
@jrodewig jrodewig added the :Core/Infra/Logging Log management and logging utilities label Oct 15, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka changed the title Add information to migration guide about JSON logs being ECS compliant [doc] Migration information about ES logging breaking changes Oct 18, 2021
@pgomulka
Copy link
Contributor Author

@jrodewig I also added information about plaintext files removal - a breaking change too. It was done in the same PR

@pgomulka pgomulka requested a review from jrodewig October 18, 2021 08:57
@jrodewig jrodewig changed the title [doc] Migration information about ES logging breaking changes [DOCS] Migration information about ES logging breaking changes Oct 19, 2021
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor suggestions for the new breaking change.

We also need to add some notable highlights for the ECS change. I left a related comment.

Thanks @pgomulka!

docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_8_0/logging.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we incorporate the suggestion we discussed offline. Thanks @pgomulka!

@pgomulka pgomulka merged commit 6aa0db8 into elastic:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Logging Log management and logging utilities >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants