Reduce memory usage and wire size of field caps internal responses #79119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
commented
Oct 14, 2021
| final boolean withOrdinals = responses.size() > 1; | ||
| output.writeBoolean(withOrdinals); | ||
| if (withOrdinals) { | ||
| final ObjectIntMap<String> dictionary = collectStringLiterals(responses); |
There was a problem hiding this comment.
We can build this map incrementally when receiving/collecting responses.
|
@ywelsch @jimczi @jtibshirani Would you mind taking a look? Thank you! |
|
Instead of making a very specific optimization, would it make sense to look into enabling transport compression on these responses? I also wonder if we should build on @original-brownbear's recent PR to intern field types (#76405), instead of introducing a separate optimization? I guess that change only helps reduce the size on the deserialization side, it doesn't affect wire size. |
|
We discussed this optimization and decided not to proceed with it. We prefer to have a new REST response where the merging logic uses smaller memory and can be scaled up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the merging logic is too complex to introduce in 7x, I'd like to introduce a simpler and contained optimization that reduces the wire size and the memory usage of internal field cap responses (i.e., FieldCapabilitiesResponse between clusters and FieldCapabilitiesNodeResponse between nodes).