Fix broken link for grok patterns in documentation #78878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current link for grok patterns does not exist anymore: https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/grok-patterns I have replaced it with: https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/ecs-v1/grok-patterns But I'm unsure if it is the right link as there is also a 'legacy' folder.
elasticsearchmachine
added
v8.0.0
external-contributor
|
Pinging @elastic/es-docs (Team:Docs) |
|
@nik9000, should we link to the ecs-1 pattern or the legacy pattern? I see differences in the patterns, but am unsure which one we should link to. |
|
@danhermann will know more. It looks like the default is the legacy patterns but I don't know if that's what the link should be. |
|
@nik9000, thanks for the ping. The default pattern set remains the legacy patterns. @lockewritesdocs, I'll leave it up to you whether you want to mention the availability of ECS-compliant patterns in addition to the legacy patterns. |
danhermann
approved these changes
Oct 12, 2021
|
@elasticmachine test this please |
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 12, 2021
* Fix broken link for grok patterns in documentation The current link for grok patterns does not exist anymore: https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/grok-patterns I have replaced it with: https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/ecs-v1/grok-patterns But I'm unsure if it is the right link as there is also a 'legacy' folder. * Update link and add section for ECS migration Co-authored-by: Adam Locke <[email protected]>
💚 Backport successful
|
|
Thanks for highlighting this broken link @stephane-deraco! |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 12, 2021
* Fix broken link for grok patterns in documentation The current link for grok patterns does not exist anymore: https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/grok-patterns I have replaced it with: https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/ecs-v1/grok-patterns But I'm unsure if it is the right link as there is also a 'legacy' folder. * Update link and add section for ECS migration Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Stéphane DERACO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link for grok patterns does not exist anymore:
https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/grok-patterns
I have replaced it with:
https://github.com/elastic/elasticsearch/blob/master/libs/grok/src/main/resources/patterns/ecs-v1/grok-patterns
But I'm unsure if it is the right link as there is also a 'legacy' folder.
--
Related to #76885