Remove uses of Joda from xpack tests #78660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joda was deprecated internally many years ago, but there still exist some tests that use it to format dates. This commit converts tests in xpack that need date parsing or printing to use Java time.
rjernst
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine update branch |
pgomulka
approved these changes
Oct 6, 2021
| @@ -137,7 +137,7 @@ public void testSimpleDateHisto() throws Exception { | |||
| "the_histo.date_histogram._count", | |||
| 2, | |||
| "the_histo.date_histogram.time_zone", | |||
| DateTimeZone.UTC.toString(), | |||
| "UTC", // TODO: the default is hardcoded from Joda, we should change this | |||
There was a problem hiding this comment.
maybe java.time.ZoneId.of("UTC").toString?
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 6, 2021
Joda was deprecated internally many years ago, but there still exist some tests that use it to format dates. This commit converts tests in xpack that need date parsing or printing to use Java time.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 7, 2021
* Remove uses of Joda from xpack tests (#78660) Joda was deprecated internally many years ago, but there still exist some tests that use it to format dates. This commit converts tests in xpack that need date parsing or printing to use Java time. * fix compile * checkstyle Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joda was deprecated internally many years ago, but there still exist
some tests that use it to format dates. This commit converts tests in
xpack that need date parsing or printing to use Java time.