-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple ILM Task Batching Implementation #78547
Merged
original-brownbear
merged 5 commits into
elastic:master
from
original-brownbear:batch-ilm-simple
Oct 1, 2021
Merged
Simple ILM Task Batching Implementation #78547
original-brownbear
merged 5 commits into
elastic:master
from
original-brownbear:batch-ilm-simple
Oct 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple implementation for ILM task batching that resolves the issue of ILM creating endless queues of tasks at `NORMAL` priority in most cases. A follow-up to this should make this more efficient by not using outright cluster state updates as batching tasks to avoid creating a series of concrete cluster states for each task which can become somewhat expensive if a larger number of tasks is batched together.
original-brownbear
added
>non-issue
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
v8.0.0
v7.16.0
labels
Oct 1, 2021
Pinging @elastic/es-data-management (Team:Data Management) |
martijnvg
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @martijnvg ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Oct 1, 2021
A simple implementation for ILM task batching that resolves the issue of ILM creating endless queues of tasks at `NORMAL` priority in most cases. A follow-up to this should make this more efficient by not using outright cluster state updates as batching tasks to avoid creating a series of concrete cluster states for each task which can become somewhat expensive if a larger number of tasks is batched together.
original-brownbear
added a commit
that referenced
this pull request
Oct 1, 2021
A simple implementation for ILM task batching that resolves the issue of ILM creating endless queues of tasks at `NORMAL` priority in most cases. A follow-up to this should make this more efficient by not using outright cluster state updates as batching tasks to avoid creating a series of concrete cluster states for each task which can become somewhat expensive if a larger number of tasks is batched together.
97 tasks
This was referenced Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
>non-issue
Team:Data Management
Meta label for data/management team
v7.16.0
v8.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation for ILM task batching that resolves the issue of ILM
creating endless queues of tasks at
NORMAL
priority in most cases.A follow-up to this should make this more efficient by not using outright
cluster state updates as batching tasks to avoid creating a series of concrete
cluster states for each task which can become somewhat expensive if a larger
number of tasks is batched together.