Rename INDEX_ROUTING_PREFER to TIER_PREFERENCE #78411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>non-issue
:Data Management/ILM+SLM
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
force-pushed
the
data-tier-preference-rename
branch
from
25dd5e6 to
f740e28
Compare
No need to poke into the implementation and re-implement this locally in terms of the set itself
In the end the version from the request or templates will be used anyway (instead of whatever we say here), so it seems more intuitive to return null as "don't care" rather than "hot (but I know you'll ignore this)".
joegallo
force-pushed
the
data-tier-preference-rename
branch
from
f740e28 to
5d4a0bf
Compare
dakrone
approved these changes
Sep 28, 2021
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/DataTier.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #76147, this is a cleanup and refactoring PR that just gets some groundwork out of the way -- here as a separate PR to keep overall noise down.
Reviewing commit by commit is probably easiest.