Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ccr info/usage actions into ccr module #78137

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 21, 2021

The ccr info and usage actions provide information through the xpack
usage nad info apis. The implemenation classes should be in each
individual module, yet for ccr they exist in xpack core, splitting the
ccr package. This commit moves the classes into the ccr module to fix
the split package.

The ccr info and usage actions provide information through the xpack
usage nad info apis. The implemenation classes should be in each
individual module, yet for ccr they exist in xpack core, splitting the
ccr package. This commit moves the classes into the ccr module to fix
the split package.
@rjernst rjernst added >non-issue :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v8.0.0 v7.16.0 labels Sep 21, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Sep 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@rjernst
Copy link
Member Author

rjernst commented Sep 21, 2021

@elasticmachine update branch

@rjernst
Copy link
Member Author

rjernst commented Sep 21, 2021

@elasticmachine run elasticsearch-ci/part-2

@ChrisHegarty ChrisHegarty mentioned this pull request Sep 22, 2021
58 tasks
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder about the 7.x backport though since it looks so different?

@rjernst
Copy link
Member Author

rjernst commented Sep 22, 2021

I wonder about the 7.x backport

It should still work in 7.x, just needs a different change. I'll backport it manually.

@rjernst rjernst merged commit 4bc09c8 into elastic:master Sep 22, 2021
@rjernst rjernst deleted the split-packages/ccr branch September 22, 2021 17:55
@rjernst
Copy link
Member Author

rjernst commented Sep 22, 2021

Oh good news, the backport isn't even needed. In 7.x the info/usage classes are not in the same location, and there is no split package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants