-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ccr info/usage actions into ccr module #78137
Conversation
The ccr info and usage actions provide information through the xpack usage nad info apis. The implemenation classes should be in each individual module, yet for ccr they exist in xpack core, splitting the ccr package. This commit moves the classes into the ccr module to fix the split package.
Pinging @elastic/es-distributed (Team:Distributed) |
@elasticmachine update branch |
@elasticmachine run elasticsearch-ci/part-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder about the 7.x backport though since it looks so different?
It should still work in 7.x, just needs a different change. I'll backport it manually. |
Oh good news, the backport isn't even needed. In 7.x the info/usage classes are not in the same location, and there is no split package. |
The ccr info and usage actions provide information through the xpack
usage nad info apis. The implemenation classes should be in each
individual module, yet for ccr they exist in xpack core, splitting the
ccr package. This commit moves the classes into the ccr module to fix
the split package.