Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split package in analysis-kuromoji plugin #78039

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 20, 2021

The analysis-kuromoji plugin reuses server package names for analysis and
mappers. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.kuromoji

The analysis-kuromoji plugin reuses server package names for analysis and
mappers. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.kuromoji
@rjernst rjernst requested a review from romseygeek September 20, 2021 20:23
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit 6403a48 into elastic:master Sep 21, 2021
@rjernst rjernst deleted the split-packages/kuromoji branch September 21, 2021 15:11
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Sep 21, 2021
The analysis-kuromoji plugin reuses server package names for analysis and
mappers. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.kuromoji
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine pushed a commit that referenced this pull request Sep 21, 2021
The analysis-kuromoji plugin reuses server package names for analysis and
mappers. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.kuromoji
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 22, 2021
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search Relevance/Analysis How text is split into tokens Team:Search Meta label for search team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants