WIP draft for ClusterStateReusingStreamInput #77982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We read various objects from the wire that already exist in the cluster state. The most notable is `DiscoveryNode` which can consume ~2kB in heap for each fresh object, but rarely changes, so it's pretty wasteful to use fresh objects here. There could be thousands (millions?) of `DiscoveryNode` objects in flight from various `TransportNodesAction` responses. This branch introduces `ClusterStateReusingStreamInput` which lets the caller capture an appropriate `ClusterState` from which to re-use `DiscoveryNode` objects if appropriate. Relates elastic#77266
DaveCTurner
added
the
:Distributed Coordination/Allocation
|
Superseded by #77991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We read various objects from the wire that already exist in the cluster
state. The most notable is
DiscoveryNodewhich can consume ~2kB inheap for each fresh object, but rarely changes, so it's pretty wasteful
to use fresh objects here. There could be thousands (millions?) of
DiscoveryNodeobjects in flight from variousTransportNodesActionresponses.
This branch introduces
ClusterStateReusingStreamInputwhich lets thecaller capture an appropriate
ClusterStatefrom which to re-useDiscoveryNodeobjects if appropriate.Relates #77266