Use enum field for HotThreads report type #77812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of elastic#77462. HotThreads report request type was declared as String, but used as an enum where only few values were allowed. This PR changes the type to enum allowing malformed requests to correctly report the error. This PR also introduces a small refactor to make the report getter function part of the accumulator class.
grcevski
added
>enhancement
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #77462
HotThreads report type field is currently declared as a String, but internally it is used as an enum. This PR changes the report type to enum and does a small refactor to encapsulate the getter function with the accumulator class.
I also extended the HotThreads unit tests to test some of the newly refactored code.
Note: This change introduces slight behaviour difference. Previously when the HotThreads API was called with an incorrect report type, e.g. /_nodes/hot_threads?type=gpu we'd crash with InvalidArgumentException, but after argument validation, therefore producing an empty 400 response. After this change we get a 400 with response: "reason": "type not supported [gpu]"