Profile the fetch phase (backport of #77064) #77633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
force-pushed
the
profile_fetch_simple_7_x
branch
from
e139550 to
8ca4b3d
Compare
This adds profiling to the fetch phase so we can tell when fetching is slower than we'd like and we can tell which portion of the fetch is slow. The output includes which stored fields were loaded, how long it took to load stored fields, which fetch sub-phases were run, and how long those fetch sub-phases took. Closes elastic#75892
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Sep 13, 2021
We make wire changes in elastic#77633 so we need to disable the backwards compatibility tests in master before merging the wire changes. We'll re-enable them after the backport is merged.
|
run elasticsearch-ci/part-2 |
|
@elasticmachine, run elasticsearch-ci/part-2 |
In elastic#77064 I added some more tests for profiling. It fails when a `rarely()` block hits - roughly 2% of the time. This should fix it.
nik9000
added a commit
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds profiling to the fetch phase so we can tell when fetching is
slower than we'd like and we can tell which portion of the fetch is
slow. The output includes which stored fields were loaded, how long it
took to load stored fields, which fetch sub-phases were run, and how
long those fetch sub-phases took.
Closes #75892