Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve FetchSourceContext and add unit tests (backport of #77346) #77521

Merged
merged 1 commit into from
Sep 9, 2021
Merged

improve FetchSourceContext and add unit tests (backport of #77346) #77521

merged 1 commit into from
Sep 9, 2021

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Sep 9, 2021

improve FetchSourceContext and add unit tests

  • add null value check in fromXContent, if no null value check, FetchSourceContextTests fromXContent tests will failed. It is similar to GetMappingsResponse.
  • fromXContent improve ParsingException's message.
  • add FetchSourceContextTests.

@nik9000 nik9000 added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.16.0 labels Sep 9, 2021
@elasticsearchmachine elasticsearchmachine merged commit c6180cf into elastic:7.x Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nik9000 @elasticsearchmachine @weizijun