Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing non snapshot ci build #77335

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix failing non snapshot ci build #77335

merged 1 commit into from
Sep 7, 2021

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Sep 7, 2021

After moving test-die-with-dignity to an external test module (see #77136) we need
to ensure the javaRestTests are only triggered in snapshot builds as they fail
on non snapshot builds.

Fixes #77326

@breskeby
Fix failing non snapshot ci build
26a48f9 
After moving test-die-with-dignity to an external test module (see elastic#77136) we need
to ensure the javaRestTests are only triggered in snapshot builds as they fail
on non snapshot builds.

Fixes elastic#77326
@breskeby breskeby self-assigned this Sep 7, 2021
@breskeby breskeby added :Delivery/Build Build or test infrastructure >enhancement auto-backport-and-merge auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0 labels Sep 7, 2021
@breskeby breskeby marked this pull request as ready for review September 7, 2021 10:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine merged commit a53230e into elastic:master Sep 7, 2021
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Sep 7, 2021
@breskeby
Fix failing non snapshot ci build (elastic#77335)
f212fef 
After moving test-die-with-dignity to an external test module (see elastic#77136) we need
to ensure the javaRestTests are only triggered in snapshot builds as they fail
on non snapshot builds.

Fixes elastic#77326
@breskeby breskeby mentioned this pull request Sep 7, 2021
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.x

elasticsearchmachine pushed a commit that referenced this pull request Sep 7, 2021
@breskeby
Fix failing non snapshot ci build (#77335) (#77344)
5912600 
After moving test-die-with-dignity to an external test module (see #77136) we need
to ensure the javaRestTests are only triggered in snapshot builds as they fail
on non snapshot builds.

Fixes #77326
@breskeby breskeby deleted the fix-release-ci-builds branch December 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@breskeby breskeby

Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >enhancement Team:Delivery Meta label for Delivery team v7.16.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release tests fail with "external test module [test-die-with-dignity] found in non-snapshot build"
4 participants
@breskeby @elasticmachine @elasticsearchmachine @jakelandis