Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MatchOnlyTextFieldMapper Retaining a Reference to its Builder #77201

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Fix MatchOnlyTextFieldMapper Retaining a Reference to its Builder #77201

merged 1 commit into from
Sep 3, 2021

Conversation

original-brownbear
Copy link
Member

Just like #77131 but for the MatchOnlyTextFieldMapper. Also, cleaned up a few
other minor things in it to make the constructor code for this class easier to follow.

@original-brownbear
Fix MatchOnlyTextFieldMapper Retaining a Reference to its Builder
3f6a279 
Just like elastic#77131 but for the `MatchOnlyTextFieldMapper`. Also, cleaned up a few
other minor things in it to make the constructor code for this class easier to follow.
@original-brownbear original-brownbear added >non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.16.0 labels Sep 2, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

romseygeek
romseygeek approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Alan!

@original-brownbear original-brownbear merged commit 38faeef into elastic:master Sep 3, 2021
@original-brownbear original-brownbear deleted the cheaper-match-only-text-field branch September 3, 2021 08:43
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Sep 3, 2021
@original-brownbear
Fix MatchOnlyTextFieldMapper Retaining a Reference to its Builder (el…
cdadb79 
…astic#77201)

Just like elastic#77131 but for the `MatchOnlyTextFieldMapper`. Also, cleaned up a few
other minor things in it to make the constructor code for this class easier to follow.
@original-brownbear original-brownbear mentioned this pull request Sep 3, 2021
Merged
original-brownbear added a commit that referenced this pull request Sep 3, 2021
@original-brownbear
Fix MatchOnlyTextFieldMapper Retaining a Reference to its Builder (#7…
9b51fc7 
…7201) (#77233)

Just like #77131 but for the `MatchOnlyTextFieldMapper`. Also, cleaned up a few
other minor things in it to make the constructor code for this class easier to follow.
@original-brownbear original-brownbear mentioned this pull request Sep 9, 2021
Open
97 tasks
@original-brownbear original-brownbear restored the cheaper-match-only-text-field branch April 18, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

@jtibshirani jtibshirani Awaiting requested review from jtibshirani

Assignees
No one assigned
Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.16.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@original-brownbear @elasticmachine @romseygeek @jakelandis