Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] ECS support for the grok processor #77059

Merged

Conversation

danhermann
Copy link
Contributor

Documents the ECS support added in #76885.

@danhermann danhermann added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.16.0 labels Aug 31, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management Meta label for data/management team labels Aug 31, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@danhermann danhermann requested a review from jrodewig September 6, 2021 16:43
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danhermann! I pushed b02bb00 to:

  • Fix the ECS links
  • Add an example including the ecs_compatibility query parameter
  • Make some minor edits

If those changes look good to you, I think this is good to go.

I also noticed we don't have formal API documentation for the Grok patterns API. I've opened #77438 to better document the API.

@danhermann
Copy link
Contributor Author

Thanks, @jrodewig!

@danhermann danhermann merged commit 09004d3 into elastic:master Sep 10, 2021
@danhermann danhermann deleted the docs_for_76885_ecs_support_in_grok branch September 10, 2021 18:10
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants