-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add descriptions to various tasks #76700
Merged
DaveCTurner
merged 3 commits into
elastic:master
from
DaveCTurner:2021-08-19-task-descriptions
Aug 20, 2021
Merged
Add descriptions to various tasks #76700
DaveCTurner
merged 3 commits into
elastic:master
from
DaveCTurner:2021-08-19-task-descriptions
Aug 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a more detailed description to get-snapshots, get-shard-snapshot, snapshots-status and field-capabilities tasks since these may somtimes be long-running things and it may occasionally be necessary to track down why they are running and what they're doing.
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.16.0
labels
Aug 19, 2021
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Aug 19, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left some small comments
...java/org/elasticsearch/action/admin/cluster/snapshots/get/shard/GetShardSnapshotRequest.java
Show resolved
Hide resolved
...ain/java/org/elasticsearch/action/admin/cluster/snapshots/status/SnapshotsStatusRequest.java
Show resolved
Hide resolved
...java/org/elasticsearch/action/admin/cluster/snapshots/get/shard/GetShardSnapshotRequest.java
Show resolved
Hide resolved
henningandersen
approved these changes
Aug 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks both! |
DaveCTurner
added a commit
that referenced
this pull request
Aug 20, 2021
Adds a more detailed description to get-snapshots, get-shard-snapshot, snapshots-status and field-capabilities tasks since these may somtimes be long-running things and it may occasionally be necessary to track down why they are running and what they're doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>enhancement
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.16.0
v8.0.0-alpha2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a more detailed description to get-snapshots, get-shard-snapshot,
snapshots-status and field-capabilities tasks since these may somtimes
be long-running things and it may occasionally be necessary to track
down why they are running and what they're doing.