Set netty available processors system property for tests globally #75699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
ywelsch
approved these changes
Jul 27, 2021
| * We have to disable setting the number of available processors as tests in the same JVM randomize processors and will step on each | ||
| * other if we allow them to set the number of available processors as it's set-once in Netty. | ||
| */ | ||
| systemProperty 'es.set.netty.runtime.available.processors', 'false' |
There was a problem hiding this comment.
configuring this here probably didn't even make sense (as it's a YML test), right?
There was a problem hiding this comment.
Correct. I suspect it was just copy/pasted from elsewhere.
…cessors_sys_prop # Conflicts: # x-pack/plugin/build.gradle
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jul 27, 2021
…astic#75699) (cherry picked from commit 9d14bc9)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 27, 2021
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
es.set.netty.runtime.available.processorssystem property globally inESTestCaserather than configuring Gradle or JUnit test runners to add it. This makes for a more consistent test execution environment and alleviates issues with the IDE not being configured properly.Closes #74737