Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable compiler warnings in :test:framework #75449

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Re-enable compiler warnings in :test:framework #75449

merged 1 commit into from
Jul 21, 2021

Conversation

pugnascotia
Copy link
Contributor

Part of #40366.

@pugnascotia pugnascotia requested a review from breskeby July 19, 2021 10:37
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jul 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@pugnascotia pugnascotia mentioned this pull request Jul 19, 2021
Closed
23 tasks
@sethmlarson sethmlarson added the Team:Clients Meta label for clients team label Jul 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

breskeby
breskeby approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@breskeby breskeby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. TIL about @SafeVarargs

@pugnascotia pugnascotia added auto-backport Automatically create backport pull requests when merged and removed auto-backport Automatically create backport pull requests when merged labels Jul 21, 2021
@pugnascotia pugnascotia merged commit cd44467 into elastic:master Jul 21, 2021
@pugnascotia pugnascotia deleted the 40366-compiler-warnings-test-framework branch July 21, 2021 12:47
pugnascotia added a commit that referenced this pull request Jul 21, 2021
@pugnascotia
Re-enable compiler warnings in :test:framework (#75449)
400029a 
Part of #40366.
@pugnascotia
Copy link
Contributor Author

Backported in 400029a.

ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
@pugnascotia @ywangd
Re-enable compiler warnings in :test:framework (elastic#75449)
1213572 
Part of elastic#40366.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breskeby breskeby breskeby approved these changes

Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Clients Meta label for clients team Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pugnascotia @elasticmachine @breskeby @jakelandis @sethmlarson