Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Rework AutoFollowIT.testAutoFollowSearchableSnapshotsFails #74603

Merged

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jun 28, 2021

The test AutoFollowIT.testAutoFollowSearchableSnapshotsFails was
added in #70580 in order to test that mounted indices of a leader
cluster are not auto-followed in a follower cluster using CCR.

This test sometimes fails because it expects 2 indices to be
followed (the -regular and the -index indices) but not the mounted
one. This looks wrong as the -index index is deleted soon after it
is snapshotted, and this index only exist to create a snapshot that
can be later mounted as an index in the leader cluster.

This commit changes the test so that the -index index, the
repository and the snapshot are created at the beginning of the
test. Then the test creates the mounted index and the regular
one and can now asserts that only the regular one was
auto-followed.

Backport of #74498
Closes #74486

…4498)

The test AutoFollowIT.testAutoFollowSearchableSnapshotsFails was
added in elastic#70580 in order to test that mounted indices of a leader
cluster are not auto-followed in a follower cluster using CCR.

This test sometimes fails because it expects 2 indices to be
followed (the -regular and the -index indices) but not the mounted
one. This looks wrong as the -index index is deleted soon after it
is snapshotted, and this index only exist to create a snapshot that
can be later mounted as an index in the leader cluster.

This commit changes the test so that the -index index, the
repository and the snapshot are created at the beginning of the
test. Then the test creates the mounted index and the regular
one and can now asserts that only the regular one was
auto-followed.

Closes elastic#74486
@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.14.0 labels Jun 28, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@tlrx tlrx merged commit 808b153 into elastic:7.x Jun 28, 2021
@tlrx tlrx deleted the rework-testAutoFollowSearchableSnapshotsFails-7.x branch June 28, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants