[Test] Enure test assertions are called for API key creation #74431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elastic#74165, API key creation has one additional async layer. Hence the test assertions are now executed asynchronously and may not get called in time before the test ends. This PR ensures the assertions are always called by waiting for a flag. Resolves: elastic#74427
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
tvernum
approved these changes
Jun 23, 2021
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Jun 23, 2021
…#74431) Since elastic#74165, API key creation has one additional async layer. Hence the test assertions are now executed asynchronously and may not get called in time before the test ends. This PR ensures the assertions are always called by waiting for a flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #74165, API key creation has one additional async layer. Hence the
test assertions are now executed asynchronously and may not get called
in time before the test ends. This PR ensures the assertions are always
called by waiting for a flag.
Resolves: #74427