-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory usage in SimpleClusterStateIT#testLargeClusterStatePublishing #73773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ishing In order to produce a large cluster state this test was creating 1000s of text fields for index mappings. The in memory representation for these mappings can consume all the heap causing OOMs. This commit changes the mapping type for a boolean that's more lightweight. Closes elastic#73050
fcofdez
added
>test
Issues or PRs that are addressing/adding tests
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
v8.0.0
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.14.0
labels
Jun 4, 2021
Pinging @elastic/es-distributed (Team:Distributed) |
@elasticmachine update branch |
original-brownbear
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine update branch |
Thanks Armin! |
fcofdez
added a commit
to fcofdez/elasticsearch
that referenced
this pull request
Jul 1, 2021
…ishing In order to produce a large cluster state this test was creating 1000s of text fields for index mappings. The in memory representation for these mappings can consume all the heap causing OOMs. This commit changes the mapping type for a boolean that's more lightweight. Closes elastic#73050 Backport of elastic#73773
fcofdez
added a commit
that referenced
this pull request
Jul 1, 2021
…ishing (#74851) In order to produce a large cluster state this test was creating 1000s of text fields for index mappings. The in memory representation for these mappings can consume all the heap causing OOMs. This commit changes the mapping type for a boolean that's more lightweight. Closes #73050 Backport of #73773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Cluster Coordination
Cluster formation and cluster state publication, including cluster membership and fault detection.
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
>test
Issues or PRs that are addressing/adding tests
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to produce a large cluster state this test creates 1000s
of text fields mappings. The in memory representation for
these mappings can consume all the heap causing OOMs. This commit
changes the mapping type for a boolean that's more lightweight.
Closes #73050