Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _meta information to built-in ILM policies #73629

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 1, 2021

We already ship templates that include the _meta map for things like component and composable
index templates, and we use the "managed": true indicator for many of our built-in items within
Elasticsearch.

This commit adds a description and managed flag to each of the ILM policies we ship by default.

We already ship templates that include the `_meta` map for things like component and composable
index templates, and we use the `"managed": true` indicator for many of our built-in items within
Elasticsearch.

This commit adds a description and managed flag to each of the ILM policies we ship by default.
@dakrone dakrone added :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.14.0 labels Jun 1, 2021
@dakrone dakrone requested a review from andreidan June 1, 2021 18:23
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@dakrone
Copy link
Member Author

dakrone commented Jun 1, 2021

@elasticmachine update branch

Copy link
Contributor

@andreidan andreidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this Lee

@dakrone dakrone merged commit 8d0fe6f into elastic:master Jun 2, 2021
@dakrone dakrone deleted the built-in-policy-meta branch June 2, 2021 13:58
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jun 2, 2021
We already ship templates that include the _meta map for things like component and composable
index templates, and we use the "managed": true indicator for many of our built-in items within
Elasticsearch.

This commit adds a description and managed flag to each of the ILM policies we ship by default.
dakrone added a commit that referenced this pull request Jun 2, 2021
We already ship templates that include the _meta map for things like component and composable
index templates, and we use the "managed": true indicator for many of our built-in items within
Elasticsearch.

This commit adds a description and managed flag to each of the ILM policies we ship by default.
@cjcenizal cjcenizal added the Team:Deployment Management Meta label for Management Experience - Deployment Management team label Jun 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cjcenizal
Copy link
Contributor

@dakrone Are these descriptions intended to be read by our end users, or intended for Elasticians? If they're intended for end users, can we sentence case this copy and run it by a writer? Can we also find a way to remove references to X-Pack, since that's no longer a term we expose our users to?

@dakrone
Copy link
Member Author

dakrone commented Jun 4, 2021

@cjcenizal I think it depends on whether the UI consumes them, I was treating them as internal descriptions, but if they're intended to be visible in things like the UI then they should probably be more thought out :)

@cjcenizal
Copy link
Contributor

Thanks Lee, that helps me understand. Do you think we should just hide managed policies entirely in the UI? Is there anything a user could gain from seeing them -- would they learn anything useful about policy configuration? Would seeing them answer any questions they might have about the behavior of the cluster?

@dakrone
Copy link
Member Author

dakrone commented Jun 4, 2021

Do you think we should just hide managed policies entirely in the UI?

Not yet, we're not at a point where they can be ignored entirely by the user yet.

Is there anything a user could gain from seeing them -- would they learn anything useful about policy configuration?

Yes, especially things like the logs, metrics, and synthetics templates that we install out of the box. Those are things that a user should be aware of if they don't use Fleet, for instance.

Would seeing them answer any questions they might have about the behavior of the cluster?

Yes, especially related to the fleet stuff (like indexing into logs-*-* with adding an integration first)

@cjcenizal
Copy link
Contributor

Great, thanks Lee. I think these are all strong arguments for surfacing the description in the UI, and refining that copy.

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jun 9, 2021
droberts195 added a commit that referenced this pull request Jun 9, 2021
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jun 10, 2021
droberts195 added a commit that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >enhancement Team:Data Management Meta label for data/management team Team:Deployment Management Meta label for Management Experience - Deployment Management team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants