-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _meta information to built-in ILM policies #73629
Conversation
We already ship templates that include the `_meta` map for things like component and composable index templates, and we use the `"managed": true` indicator for many of our built-in items within Elasticsearch. This commit adds a description and managed flag to each of the ILM policies we ship by default.
Pinging @elastic/es-core-features (Team:Core/Features) |
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this Lee
We already ship templates that include the _meta map for things like component and composable index templates, and we use the "managed": true indicator for many of our built-in items within Elasticsearch. This commit adds a description and managed flag to each of the ILM policies we ship by default.
We already ship templates that include the _meta map for things like component and composable index templates, and we use the "managed": true indicator for many of our built-in items within Elasticsearch. This commit adds a description and managed flag to each of the ILM policies we ship by default.
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
@dakrone Are these descriptions intended to be read by our end users, or intended for Elasticians? If they're intended for end users, can we sentence case this copy and run it by a writer? Can we also find a way to remove references to X-Pack, since that's no longer a term we expose our users to? |
@cjcenizal I think it depends on whether the UI consumes them, I was treating them as internal descriptions, but if they're intended to be visible in things like the UI then they should probably be more thought out :) |
Thanks Lee, that helps me understand. Do you think we should just hide managed policies entirely in the UI? Is there anything a user could gain from seeing them -- would they learn anything useful about policy configuration? Would seeing them answer any questions they might have about the behavior of the cluster? |
Not yet, we're not at a point where they can be ignored entirely by the user yet.
Yes, especially things like the logs, metrics, and synthetics templates that we install out of the box. Those are things that a user should be aware of if they don't use Fleet, for instance.
Yes, especially related to the fleet stuff (like indexing into |
Great, thanks Lee. I think these are all strong arguments for surfacing the |
This was missed in elastic#73629
This was missed in elastic#73629 Backport of elastic#73961
We already ship templates that include the
_meta
map for things like component and composableindex templates, and we use the
"managed": true
indicator for many of our built-in items withinElasticsearch.
This commit adds a description and managed flag to each of the ILM policies we ship by default.